Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show root process in incident notification #1594

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

markostreich
Copy link
Contributor

@markostreich markostreich commented Apr 18, 2024

Description

Reference

Issues: #1401

Screenshots (If UI changed)

Check-List

  • All Acceptance criteria of user story are met
  • Accessibility was considered and tested (On UI Change)
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
    - [ ] Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date
    - [ ] Internal Services / Artifacts updated (Depending on Change - See Dependency Graph)
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

@markostreich markostreich self-assigned this Apr 18, 2024
@markostreich markostreich marked this pull request as draft April 18, 2024 07:40
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.68%. Comparing base (68840a0) to head (3166a64).

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1594   +/-   ##
=========================================
  Coverage     44.68%   44.68%           
  Complexity     1696     1696           
=========================================
  Files           651      651           
  Lines          9603     9603           
  Branches        475      475           
=========================================
  Hits           4291     4291           
  Misses         5132     5132           
  Partials        180      180           
Flag Coverage Δ
unittests 44.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markostreich markostreich marked this pull request as ready for review April 24, 2024 07:15
@darenegade darenegade self-requested a review April 24, 2024 07:19
Copy link
Member

@darenegade darenegade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

War dann ja doch ganze einfach😅

@markostreich markostreich merged commit cc285b2 into dev Apr 24, 2024
21 of 23 checks passed
@markostreich markostreich deleted the feature/show-root-process-in-notification branch April 24, 2024 07:42
markostreich added a commit that referenced this pull request Apr 24, 2024
* 1401 show root process in incident notification

* 1401 refactor
markostreich added a commit that referenced this pull request Apr 25, 2024
* 1401 show root process in incident notification

* 1401 refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants